Merged
Conversation
github-actions
bot
added
parquet
alamb
commented
Aug 7, 2025
| .unwrap() | ||
| .to_string(); | ||
| let pretty = | ||
| pretty_format_columns_with_options("pretty", std::slice::from_ref(&array), &opts) |
Contributor
Author
There was a problem hiding this comment.
avoiding the clone seems good to me
| #[allow(clippy::redundant_static_lifetimes)] | ||
| #[allow(clippy::redundant_field_names)] | ||
| #[allow(non_camel_case_types)] | ||
| #[allow(mismatched_lifetime_syntaxes)] |
Contributor
Author
There was a problem hiding this comment.
this lint is ignored because this is all generated code
| assert_eq!(sync_buffer, async_buffer); | ||
| } | ||
|
|
||
| struct TestAsyncSink { |
Contributor
Author
There was a problem hiding this comment.
clippy now notices this is dead code
timsaucer
approved these changes
Aug 7, 2025
Member
timsaucer
left a comment
timsaucer
left a comment
There was a problem hiding this comment.
Thanks for doing the update!
Contributor
|
Looks good to me, I noticed these lifetime recommendations earlier when testing the beta release. |
Contributor
Author
|
Thanks @timsaucer and @jhorstmann |
Contributor
Author
|
BTW @EricccTaiwan and I have a PR to explicitly specify the rust-toolchain to have a consistent build: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Clippy is failing on main. Here is an example
Rust 1.89 was released today and it includes a new clippy version that
is more strict about some lints: https://blog.rust-lang.org/2025/08/07/Rust-1.89.0/
What changes are included in this PR?
Fix clippy lints to make CI pass with Rust 1.89
Are these changes tested?
By CI
Are there any user-facing changes?