[Parquet] Use u64 for SerializedPageReaderState.offset & remaining_bytes, instead of usize
#7918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jigao Luo <[email protected]>
Signed-off-by: Jigao Luo <[email protected]>
JigaoLuo
changed the title
u64 for SerializedPageReaderState.offset & remaining_bytes, instead of usizeu64 for SerializedPageReaderState.offset & remaining_bytes, instead of usize
Signed-off-by: Jigao Luo <[email protected]>
XiangpengHao
approved these changes
Jul 12, 2025
Contributor
XiangpengHao
left a comment
XiangpengHao
left a comment
There was a problem hiding this comment.
Thank you @JigaoLuo this looks good to me! left minor optional doc change.
Signed-off-by: Jigao Luo <[email protected]>
Contributor
Author
|
Thank you @XiangpengHao for reviewing. I have updated the doc. |
alamb
approved these changes
Jul 12, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @JigaoLuo and @XiangpengHao -- this makes sense to me
@etseidl or @jhorstmann do you have any concerns about this change?
Contributor
|
Looks good to me, thanks! |
mbrobbel
approved these changes
Jul 14, 2025
Contributor
|
Thanks again @JigaoLuo and thanks @mbrobbel and @jhorstmann |
Contributor
Author
|
Thank you to all the reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
SerializedPageReaderState.offset&remaining_bytesbeu64instead ofusize? #7910Rationale for this change
There is a copy from my issue page:
arrow-rs/parquet/src/file/serialized_reader.rs
Lines 471 to 472 in 2be261b
What changes are included in this PR?
This PR does type changes only for
SerializedPageReaderState.offset&remaining_bytesAre these changes tested?
I can pass with local unit tests via
cargo test -p parquetAre there any user-facing changes?
No