Implement cast and other operations on decimal32 and decimal64 #7815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Apparently I don't understand "cargo fmt"; it complains about lines I haven't edited -- but only when I've edited other lines in the same file. |
mbrobbel
reviewed
Jul 14, 2025
alamb
approved these changes
Aug 18, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @CurtHagenlocher and @mbrobbel
I went through this code and reviewed the test coverage and I found it all quite thorough and following the existing patterns. Very nice 👌
Any other thoughts before we merge it?
Contributor
|
The CI failure looks like an infrastructure problem: https://github.com/apache/arrow-rs/actions/runs/17078845261/job/48427216644?pr=7815 I'll retrigger it when possible |
Contributor
|
The docs CI failure is unrelated. 🚀 |
Contributor
|
Thanks again @CurtHagenlocher |
This was referenced Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of addressing #6661 but does not close it; there is at least one more PR for CSV/Parquet/JSON support.
What changes are included in this PR?
This change adds cast operations for the recently-added
decimal32anddecimal64types. It also adds tests to verify that sort and comparison work correctly, and includes these types in benchmarks.Are these changes tested?
Yes.
Are there any user-facing changes?
Casting to and from
decimal32anddecimal64is now supported.