Repository navigation
Fix: Converted feature flight-sql-experimental to flight-sql - #7546
Merged
crepererum merged 4 commits intoMay 28, 2025
Merged
Conversation
github-actions
Bot
added
arrow
Contributor
|
Thank you for your contribution @kunalsinghdadhwal 🙏 I think there will be several other places in the code that need to be updated: Updating the README is also important: arrow-rs/arrow-flight/README.md Line 46 in 531370f But all in all this looks good to me. |
Contributor
Author
|
will update the readme as well @alamb Should i also change all the occurences of |
Contributor
Yes please |
Contributor
Author
|
Done |
alamb
approved these changes
May 27, 2025
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @kunalsinghdadhwal -- this looks great to me
I made a follow on PR while this was on my mind to remove the old flag too
crepererum
approved these changes
May 28, 2025
etseidl
pushed a commit
that referenced
this pull request
Jun 27, 2025
# Which issue does this PR close? - Follow on to #7546 - Related to #7498 # Rationale for this change We added a better named `flight-sql` feature in #7546 and I wanted to make a PR to remove the old flag while it was top of mind # What changes are included in this PR? Remove old feature flag # Are there any user-facing changes? Old feature flag will no longer work
ahirner
added a commit
to ahirner/datafusion-flight-sql-server
that referenced
this pull request
Oct 18, 2025
backkem
pushed a commit
to datafusion-contrib/datafusion-flight-sql-server
that referenced
this pull request
Oct 19, 2025
* arrow flight-sql is quite stable apache/arrow-rs#7546 and to be rm in apache/arrow-rs#7551 * df 50, arrow 56, tonic 13
Jefffrey
pushed a commit
that referenced
this pull request
Aug 3, 2026
- Closes #10276. ## Rationale for this change The `flight-sql-experimental` feature in `arrow-flight` was previously renamed to `flight-sql` in #7498 and #7546. The `flight-sql-experimental` feature was kept as an alias for backwards compatibility, with a TODO note indicating it should be removed in the next release. Since this requires a major release, it is now time to remove it completely. ## What changes are included in this PR? - Removed the `flight-sql-experimental` feature definition from `arrow-flight/Cargo.toml`. ## Are these changes tested? Yes, existing CI tests will cover this (since it just removes an alias feature flag). ## Are there any user-facing changes? Yes, any users still depending on the `flight-sql-experimental` feature flag will now need to update their `Cargo.toml` to use `flight-sql` instead. Co-authored-by: Harshalj2108 <[email protected]> Co-authored-by: Andrew Lamb <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
flight-sql-experimentaltoflight-sql#7498Rationale for this change
Just some Cargo.toml changes
What changes are included in this PR?
Changed the
flight-sql-experimentalfeature flag toflight-sqlwith backwards compatibility in arrow-flightAre there any user-facing changes?
No