Skip to content

Conversation

@masonh22
Copy link
Contributor

Which issue does this PR close?

Closes #7438.

Rationale for this change

This makes it so that the result of ParquetMetaDataReader::decode_footer_tail is usable by other crates.

What changes are included in this PR?

This just adds FooterTail to a pub use line for the reader module.

Are there any user-facing changes?

I don't think so.

@github-actions github-actions bot added the parquet Changes to the parquet crate label Apr 23, 2025
@alamb alamb changed the title pub use FooterTail Make FooterTail public Apr 28, 2025
@alamb
Copy link
Contributor

alamb commented Apr 28, 2025

I verified that FooterTail is indeed not public: https://docs.rs/parquet/latest/parquet/file/metadata/struct.ParquetMetaDataReader.html#method.decode_footer_tail

Thank you @masonh22 🙏

Copy link
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@alamb alamb merged commit 2b3a821 into apache:main Apr 30, 2025
17 checks passed
@alamb
Copy link
Contributor

alamb commented Apr 30, 2025

Thanks again @masonh22 and @etseidl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move parquet::file::metadata::reader::FooterTail to parquet::file::metadata so that it is public

3 participants