Print row, data present, expected type, and row number in error messages for arrow-csv #7361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Mar 31, 2025
Contributor
Author
|
Sure! I'll add tests which cover more cases, I noticed that the tests weren't really handling all the errors but thought of adding that as another enhancement. |
Contributor
|
I think it would be very valuable to add tests -- if you want to make a separate PR first to add error tests that would be great too. |
Contributor
Author
|
I will add it in this PR itself |
Contributor
|
Thanks @psiayn ! |
Contributor
|
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look |
Contributor
|
❤️ -- I kicked off the CI checks on this PR too |
Contributor
|
FYI @niebayes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
This change allows for better error messages in the arrow-csv crate as suggested in the issue for ease of debugging. Row number is still for a batch not the csv file, so it shows the entire row.
Are there any user-facing changes?
The changed don't affect public APIs.