Add missing type annotation #7326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
maybe the other project uses an older rust compiler 🤔 |
Member
Author
The latest stable (1.85.1). |
Contributor
|
Really weird |
mbrobbel
added a commit
to mbrobbel/arrow-rs
that referenced
this pull request
Mar 25, 2025
alamb
pushed a commit
that referenced
this pull request
Mar 26, 2025
* bugfix: correct offsets when serializing a list of fixed sized list and non-zero start offset (#7318) * When serializing fixed length arrays, adjust the offsets for writing out * Add unit test * clippy warnings * Add unit test for nulls * Update unit test to account for which schema had nulls * Add missing type annotation (#7326) * Update version * Create changelog --------- Co-authored-by: Tim Saucer <[email protected]>
alamb
pushed a commit
that referenced
this pull request
Mar 27, 2025
* bugfix: correct offsets when serializing a list of fixed sized list and non-zero start offset (#7318) * When serializing fixed length arrays, adjust the offsets for writing out * Add unit test * clippy warnings * Add unit test for nulls * Update unit test to account for which schema had nulls * Add missing type annotation (#7326) * Update version * Create changelog --------- Co-authored-by: Matthijs Brobbel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I'm not sure why
rustcfails to infer the type here. This showed up after updatingparquetto0.54.3(as a dependency of a different crate).What changes are included in this PR?
Add type annotation.
Are there any user-facing changes?
No.