-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adopt MSRV policy #7314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt MSRV policy #7314
Conversation
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @psvri -- I think this is great. I will also send a note to the mailing list for wider visibility
I think we should wait several days until we merge this PR to give others a chance to comment
Co-authored-by: Raphael Taylor-Davies <[email protected]>
Co-authored-by: Matthijs Brobbel <[email protected]>
|
I plan to merge this in 2 days so that it will have been open for a week to allow time for comment Thanks for driving this to completion @psvri |
etseidl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Co-authored-by: Ed Seidl <[email protected]>
|
ok, its been open for a week -- let's do this! |
|
Thanks everyone -- this was a long time coming! |
|
Thanks everyone for the help in merging this. |
Which issue does this PR close?
Rationale for this change
Adopt MSRV policy
What changes are included in this PR?
Creating a PR based on the comment #181 (comment) and conversations in that ticket
Are there any user-facing changes?
No