Skip to content

Conversation

@psvri
Copy link
Contributor

@psvri psvri commented Mar 20, 2025

Which issue does this PR close?

Rationale for this change

Adopt MSRV policy

What changes are included in this PR?

Creating a PR based on the comment #181 (comment) and conversations in that ticket

Are there any user-facing changes?

No

@psvri psvri changed the title Add MSRV policy Adopt MSRV policy Mar 20, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @psvri -- I think this is great. I will also send a note to the mailing list for wider visibility

I think we should wait several days until we merge this PR to give others a chance to comment

@alamb alamb mentioned this pull request Mar 20, 2025
Co-authored-by: Raphael Taylor-Davies <[email protected]>
@alamb alamb mentioned this pull request Mar 24, 2025
@alamb
Copy link
Contributor

alamb commented Mar 25, 2025

I plan to merge this in 2 days so that it will have been open for a week to allow time for comment

Thanks for driving this to completion @psvri

Copy link
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mbrobbel mbrobbel mentioned this pull request Mar 26, 2025
@alamb
Copy link
Contributor

alamb commented Mar 27, 2025

ok, its been open for a week -- let's do this!

@alamb alamb merged commit 2c2e514 into apache:main Mar 27, 2025
9 checks passed
@alamb
Copy link
Contributor

alamb commented Mar 27, 2025

Thanks everyone -- this was a long time coming!

@psvri psvri deleted the msrv branch March 28, 2025 07:37
@psvri
Copy link
Contributor Author

psvri commented Mar 28, 2025

Thanks everyone for the help in merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt a MSRV policy

5 participants