Add a note on rust compiler testing and compatibility#726
Merged
houqp merged 2 commits intoapache:masterfrom Aug 28, 2021
Merged
Add a note on rust compiler testing and compatibility#726houqp merged 2 commits intoapache:masterfrom
houqp merged 2 commits intoapache:masterfrom
Conversation
github-actions
bot
added
arrow
This was referenced Aug 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
==========================================
+ Coverage 82.50% 82.51% +0.01%
==========================================
Files 168 168
Lines 47589 47631 +42
==========================================
+ Hits 39261 39301 +40
- Misses 8328 8330 +2
Continue to review full report at Codecov.
|
houqp
approved these changes
Aug 28, 2021
alamb
added a commit
that referenced
this pull request
Sep 9, 2021
* Add a note on rust compiler testing and compatibility * prettier
alamb
added a commit
that referenced
this pull request
Sep 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
@jhorstmann noticed a change that was introduced in #714 (comment) (and included in the arrow 5.3.0 RC0) that is incompatible with rust 1.52.1 (rust is currently on 1.54.0).
What changes are included in this PR?
Propose explicitly document that arrow and parquet are only tested with the latest stable version of Rust.
Though this maybe also should serve as a way to solicit opinions about how important compatibility with older versions of Rust is (and if anyone would be willing to spend the time to setup CI to make sure that happens)
Are there any user-facing changes?
Different readme