Minor: Clarify NullBufferBuilder::new capacity parameter#7016
Merged
tustvold merged 2 commits intoapache:mainfrom Jan 25, 2025
Merged
Minor: Clarify NullBufferBuilder::new capacity parameter#7016tustvold merged 2 commits intoapache:mainfrom
tustvold merged 2 commits intoapache:mainfrom
Conversation
Jefffrey
reviewed
Jan 24, 2025
Co-authored-by: Jeffrey Vo <[email protected]>
Jefffrey
approved these changes
Jan 24, 2025
Contributor
Author
|
Thanks @Jefffrey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
is_validandtruncatemethods toNullBufferBuilder#7013Rationale for this change
I was confused about how
capacityworked for theNullBufferBuilderin #7013 (comment) while discussing with @Jefffrey and @ Chen-Yuan-Lai and spent some time reading the code.I would like to document my findings in docstrings for the next time
What changes are included in this PR?
Add doc comments about
capacityAre there any user-facing changes?
Docs only. There are no functional changes