Skip to content

Comments

Export NullBufferBuilder along with BooleanBufferBuilder in arrow crate#6976

Merged
alamb merged 2 commits intoapache:mainfrom
alamb:alamb/export_null_buffer-builder
Jan 21, 2025
Merged

Export NullBufferBuilder along with BooleanBufferBuilder in arrow crate#6976
alamb merged 2 commits intoapache:mainfrom
alamb:alamb/export_null_buffer-builder

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jan 13, 2025

Which issue does this PR close?

Rationale for this change

Since NullBuffer is not re-exported in arrow it is hard to find downstream

What changes are included in this PR?

  1. Export NullBufferBuilder along with BooleanBufferBuilder in arrow crate
  2. Add some doc examples

Are there any user-facing changes?

NullBufferBuilder can be used from the arrow rate. For example:

Screenshot 2025-01-13 at 3 47 01 PM

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 13, 2025
Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb
Copy link
Contributor Author

alamb commented Jan 21, 2025

Thank you for the review @Jefffrey

@alamb alamb merged commit 4b38ff5 into apache:main Jan 21, 2025
26 checks passed
@alamb alamb deleted the alamb/export_null_buffer-builder branch January 21, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-export NullBufferBuilder in the arrow crate

2 participants