Document how to use Extend for generic methods on ArrayBuilders#6932
Merged
tustvold merged 2 commits intoapache:mainfrom Jan 4, 2025
Merged
Document how to use Extend for generic methods on ArrayBuilders#6932tustvold merged 2 commits intoapache:mainfrom
tustvold merged 2 commits intoapache:mainfrom
Conversation
wiedld
force-pushed
the
wiedld/doc-builder-extend-methods
branch
from
42a3f55 to
e207ee8
Compare
wiedld
force-pushed
the
wiedld/doc-builder-extend-methods
branch
from
644b6a1 to
4bb179b
Compare
Contributor
Author
|
@tlm365 -- here is the documentation on how to replace those macros with generics (if you decide to do so). |
Contributor
CurtHagenlocher
pushed a commit
to CurtHagenlocher/arrow-rs
that referenced
this pull request
Jan 13, 2025
…he#6932) * chore: add docs for how to use Extend for generic methods on ArrayBuilders * chore: move to mod docs and add more examples
svencowart
pushed a commit
to elastiflow/arrow-rs
that referenced
this pull request
Jan 14, 2025
…he#6932) * chore: add docs for how to use Extend for generic methods on ArrayBuilders * chore: move to mod docs and add more examples
totoroyyb
pushed a commit
to totoroyyb/arrow-rs
that referenced
this pull request
Jan 20, 2025
…he#6932) * chore: add docs for how to use Extend for generic methods on ArrayBuilders * chore: move to mod docs and add more examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Improve docs per this conversation, for how to use the Extend implementations of ArrayBuilders in order to build generic functions over these builders.
Rationale for this change
As noticed in this code review, where declarative macros were used instead of generics. All involved were not aware of this alternative approach of using the Extend for generic functions over the builders. Therefore, provide more docs.
What changes are included in this PR?
Docs only.
Are there any user-facing changes?
Docs only.