Minor: make it easier to find fix instructions when cargo fmt on parquet fails#6886
Merged
tustvold merged 4 commits intoapache:mainfrom Dec 18, 2024
Merged
Conversation
This reverts commit 440e520.
2c28558 to
3da1765
Compare
etseidl
approved these changes
Dec 17, 2024
Contributor
etseidl
left a comment
There was a problem hiding this comment.
🚀 Nice. Just a small correction.
Co-authored-by: Ed Seidl <[email protected]>
Contributor
Author
Nice catch -- thank you |
tustvold
approved these changes
Dec 17, 2024
Contributor
tustvold
left a comment
There was a problem hiding this comment.
Is there a reason we have such an arcane incantation?
Contributor
Author
Contributor
In particular, things like Lines 137 to 138 in 54dccad cargo fmt. I agree the incantation is not desirable, and was meant to be a stop-gap until a better solution can be found.
|
Contributor
Author
Filed #6897 to track |
CurtHagenlocher
pushed a commit
to CurtHagenlocher/arrow-rs
that referenced
this pull request
Dec 28, 2024
…rquet fails (apache#6886) * Minor: make it easier to find instructions when fmt fails * purposely introduce a fmt issue * Revert "purposely introduce a fmt issue" This reverts commit 440e520. * Update .github/workflows/rust.yml Co-authored-by: Ed Seidl <[email protected]> --------- Co-authored-by: Ed Seidl <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
While working on #6840 the
fmtci check failed on parquet. For example: https://github.com/apache/arrow-rs/actions/runs/12361198145/job/34497838320However, the exact recipe to fix this was not clear (you have to run a certain command within the arquet directory)
What changes are included in this PR?
Example https://github.com/apache/arrow-rs/actions/runs/12361621609/job/34499177568?pr=6886
Are there any user-facing changes?