Skip to content

Improve MSRV failure CI JOB output display#6854

Closed
alamb wants to merge 3 commits intoapache:mainfrom
alamb:alamb/better_msrv_output
Closed

Improve MSRV failure CI JOB output display#6854
alamb wants to merge 3 commits intoapache:mainfrom
alamb:alamb/better_msrv_output

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Dec 7, 2024 •
edited
Loading

Which issue does this PR close?

Closes #.

Rationale for this change

While debugging #6853 with @andygrove and @viirya , the CI output display for MSRV failures look 🤮 and doesn't tell you what the problem is

https://github.com/apache/arrow-rs/actions/runs/12207850027/job/34060002164?pr=6853

Screenshot 2024-12-07 at 7 42 10 AM

What changes are included in this PR?

It seems msrv has improved thier display since we list made this better

andrewlamb@Andrews-MacBook-Pro-2:~/Software/arrow-rs/arrow$ cargo msrv verify
  [Meta]   cargo-msrv 0.17.1

Compatibility Check #1: Rust 1.70.0
  [FAIL]   Is incompatible

  ╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
  │ error: package `clap v4.5.23` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.70.0 │
  │ Either upgrade to rustc 1.74 or newer, or use                                                                                             │
  │ cargo update -p [email protected] --precise ver                                                                                                 │
  │ where `ver` is the latest version of `clap` supporting rustc 1.70.0                                                                       │
  │                                                                                                                                           │
  ╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

Are there any user-facing changes?

Example of new MSRV failure
XXX

@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 7, 2024
@viirya
Copy link
Member

viirya commented Dec 7, 2024 

cargo msrv verify
  shell: sh -e {0}
  env:
    RUSTFLAGS: -C debuginfo=1
    RUST_BACKTRACE: 1
Error: Process completed with exit code 1.

Looks like not working?

@alamb
Copy link
Contributor Author

alamb commented Dec 7, 2024 

cargo msrv verify
  shell: sh -e {0}
  env:
    RUSTFLAGS: -C debuginfo=1
    RUST_BACKTRACE: 1
Error: Process completed with exit code 1.

Looks like not working?

Yeah, compared to the output with a tty this output is not good (probably why we dumped the logs).

I will maybe add a note / comment to the job instead saying that running cargo msrv locally will print out a nice error message

@alamb alamb closed this Dec 7, 2024
@alamb alamb mentioned this pull request Dec 7, 2024
Merged
@alamb alamb reopened this Dec 7, 2024
@alamb alamb closed this Dec 7, 2024
@alamb
Copy link
Contributor Author

alamb commented Dec 7, 2024

I have another idea I am trying out #6857

Will mark as ready for review if it looks reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

arrow Changes to the arrow crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alamb @viirya