Skip to content

Comments

Fix string view ILIKE checks with NULL values#6705

Merged
alamb merged 1 commit intoapache:masterfrom
findepi:findepi/fix-string-view-ilike-checks-with-null-values-2c7b71
Nov 8, 2024
Merged

Fix string view ILIKE checks with NULL values#6705
alamb merged 1 commit intoapache:masterfrom
findepi:findepi/fix-string-view-ilike-checks-with-null-values-2c7b71

Conversation

@findepi
Copy link
Member

@findepi findepi commented Nov 8, 2024

Which issue does this PR close?

Rationale for this change

Fix correctness

What changes are included in this PR?

Fix StringView LIKE .. result when tested values include nulls.

Are there any user-facing changes?

Yes

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 8, 2024
@findepi
Copy link
Member Author

findepi commented Nov 8, 2024

@alamb ptal

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @findepi

@alamb alamb merged commit a2a80ca into apache:master Nov 8, 2024
@findepi findepi deleted the findepi/fix-string-view-ilike-checks-with-null-values-2c7b71 branch November 8, 2024 18:53
findepi added a commit to sdf-labs/arrow-rs that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants