Remove test_private_bucket object_store test#6601
Conversation
object_store/src/aws/resolve.rs
Outdated
| #[tokio::test] | ||
| async fn test_private_bucket() { | ||
| let bucket = "bloxbender"; | ||
| let bucket = "public-datasets"; |
There was a problem hiding this comment.
the test is called private-bucket but then uses no authentication. I don't know what to make of this.
Maybe @tustvold remembers
There was a problem hiding this comment.
IIRC it was a test to make sure resolve_region worked for private buckets without needing credentials.
|
I think we can probably just remove this test, its effectively just testing a behaviour of S3 which isn't going to change |
removed in 46a8e0a |
| use super::*; | ||
|
|
||
| #[tokio::test] | ||
| async fn test_private_bucket() { |
There was a problem hiding this comment.
the PR description says "Fix test_private_bucket object_store test"
and "Change to use another s3 bucket"
let's maybe update both before merge
alamb
changed the title
test_private_bucket object_store testtest_private_bucket object_store test
* Fix `test_private_bucket` test * remove test
* Fix `test_private_bucket` test * remove test
* Fix `test_private_bucket` test * remove test
4 participants
Which issue does this PR close?
Closes apache/arrow-rs-object-store#42
Rationale for this change
The test is failing on main
I think it is due to whatever the
bloxblenders3 bucket being movedWhat changes are included in this PR?
Remove the test as it is testing some behavior of S3 (see @tustvold 's comment below)
Are there any user-facing changes?
No this is a test only