Add ColumnChunkMetadataBuilder clear APIs#6523
Merged
tustvold merged 1 commit intoapache:masterfrom Oct 8, 2024
Merged
Conversation
alamb
force-pushed
the
alamb/clear_stats
branch
from
7b7a912 to
02d8b98
Compare
alamb
commented
Oct 7, 2024
| } | ||
|
|
||
| /// Clears the statistics for this column chunk. | ||
| pub fn clear_statistics(mut self) -> Self { |
Contributor
Author
There was a problem hiding this comment.
Unfortunately, set_statistics takes value: Statistics not value: Option<Statistics> and thus there is no way to make this change without breaking the API which we can't do until the next breaking release
| } | ||
|
|
||
| /// Clears the page encoding stats for this column chunk. | ||
| pub fn clear_page_encoding_stats(mut self) -> Self { |
Contributor
Author
There was a problem hiding this comment.
The same reasoning applies to this API
etseidl
approved these changes
Oct 7, 2024
Contributor
etseidl
left a comment
etseidl
left a comment
There was a problem hiding this comment.
Looks good. Seems straightforward enough to not need additional tests. I agree it would be nice to change the setters to take Options. That can be done in a follow-up. Thanks!
tustvold
approved these changes
Oct 8, 2024
Contributor
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
This seems like a pragmatic way forward to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6504
Rationale for this change
I want to use the
ColumnChunkMetaDataBuilderto modify existing metadata in addition to creating new metadata, for the example in #6504.What changes are included in this PR?
ColumnChunkMetadataBuilder::clear_statisticsand other clear API to modifyOptionfieldsAre there any user-facing changes?
Some new APIs and docs