Conversation
github-actions
bot
added
arrow
|
@alamb please have a look. The only culprits that remain now are parquet and arrow-ipc, with over 200 & 850 warnings each, so they'll take some time. But we're in the right direction. |
|
Okay turns out these warnings were not emitted when tested using clippy. I'll fix these soon and circle back on this. |
ByteBaker
force-pushed
the
require_docs
branch
3 times, most recently
from
743da3d to
3b5b3b0
Compare
|
@alamb I'm not sure what to do about vendored code. Some guidance/help needed here. |
ByteBaker
force-pushed
the
require_docs
branch
from
3b5b3b0 to
6361835
Compare
ByteBaker
force-pushed
the
require_docs
branch
from
6361835 to
064f973
Compare
Since this code is auto generated, I think we should disable any clippy lints that are failing for it rather than try to add documentation |
- add pragma `#![warn(missing_docs)]` to the following - `arrow-flight` - `arrow-ipc` - `arrow-integration-test` - `arrow-integration-testing` - `object_store` - also document the caveat with using level 10 GZIP compression in parquet. See apache#6282.
ByteBaker
force-pushed
the
require_docs
branch
from
064f973 to
618c775
Compare
|
Weird that I missed this. I've been doing this for every autogenerated file so far. Somehow I thought the error was coming from running |
|
@alamb the PR is updated and ready for review. |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you so much @ByteBaker -- this PR is almost perfect. I think the only thing that needs to be fixed is the potential panic in log_metadata.
arrow-integration-testing/src/flight_server_scenarios/integration_test.rs
Show resolved
Hide resolved
|
The changes have been incorporated. Please review. |
|
The warning is due to a spurious network issue. The same test has passed in previous run. I think we can merge this, or maybe run the failed step again just be extra sure. |
|
Epic -- thanks again @ByteBaker |
|
@alamb I'm just happy to make Arrow better! 😅 One more PR and it'll be complete, end to end. |
|
We appreciate it very much |
* chore: add docs, part of #37 - add pragma `#![warn(missing_docs)]` to the following - `arrow-flight` - `arrow-ipc` - `arrow-integration-test` - `arrow-integration-testing` - `object_store` - also document the caveat with using level 10 GZIP compression in parquet. See apache#6282. * chore: resolve PR comments from apache#6453
2 participants
add pragma
#![warn(missing_docs)]to the followingarrow-flightarrow-ipcarrow-integration-testarrow-integration-testingobject_storeadd documentation to remove any warnings thus generated
also document the caveat with using level 10 GZIP compression in Parquet. Closes What is the highest compression level in gzip? #6282.