Implement do_put_statement_ingest handler in FlightSqlService#6137
Implement do_put_statement_ingest handler in FlightSqlService#6137djanderson wants to merge 4 commits intoapache:53.0.0-devfrom
Conversation
github-actions
bot
added
arrow
djanderson
changed the title
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @djanderson 🙏
I wonder if you could also add a test for this code to show all the plumbing is hooked up correctly
Perhaps you could follow the model in https://github.com/apache/arrow-rs/blob/master/arrow-flight/tests/flight_sql_client.rs (thanks to @lewiszlw for setting up that pattern)
djanderson
force-pushed
the
do-put-statement-ingest
branch
from
ba60aa3 to
acf331a
Compare
Dispatch this handler for the new CommandStatementIngest command.
djanderson
force-pushed
the
do-put-statement-ingest
branch
from
acf331a to
b505037
Compare
|
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look |
|
BTW when you next get a chance to work on this PR, can you please change it so it targets the |
|
@alamb of course. I'm working on it, I'll open a PR against |
|
It appears that github automatically closes the PR when the target branch is deleted -- sorry about that |
2 participants
Which issue does this PR close?
Closes #6124.
Depends on #6133.
Rationale for this change
This implements the handler for the new
CommandStatementIngestmessage defined in Arrow Flight SQL version 17.0.What changes are included in this PR?
The generated
CommandStatementIngestfrom #6133 is exposed as a public member of the arrow_flightsqlmodule and theFlightSqlServicetrait is updated with a handler for that new command.Are there any user-facing changes?
Yes, the trait
FlightSqlServicehas a new method,do_put_statement_ingest.This PR should be tagged
api-change.