Closed
Conversation
5 tasks
progval
reviewed
Jul 17, 2024
Comment on lines
+131
to
+135
| Our [release schedule] allows breaking API changes only in major releases. This | ||
| means that if your PR has a breaking API change, it should be marked with the | ||
| labels: `api-change` and `next-major-release` and it will not be merged to | ||
| `master` until development opens for the next major release. See [this ticket] for | ||
| details. |
Contributor
There was a problem hiding this comment.
I don't think contributors can set labels. You'll need to configure a bot to set the label based on the target branch.
Contributor
Author
|
I am not sure how great this idea was - so marking this as draft until we may need to do it again |
Contributor
|
Should we close this? |
Contributor
Author
Yeah, I think we can reopen/ revive it if we want to do a dev branch again. I would say it was non ideal and going with the 'deprecate and make new APIs' was better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to apache/arrow-rs-object-store#63
Related to #6016
Rationale for this change
We ended up with many PRs stacked up waiting to merge to
mainthat could not because they had breaking changes (see discussion on apache/arrow-rs-object-store#63)For
53.0.0we tried making a feature branch,53.0.0-dev, to collect PRs with breaking changes beforemasteropens.This PR documents how that worked
I plan to update it as we
What changes are included in this PR?
Update
CONTRIBUTING.mddocumentAre there any user-facing changes?
Docs