implement new_null_array for view types#5894
Conversation
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @XiangpengHao
As I start integrating view types in DataFusion, I expect more such unhandled cases to surface. Let me know if we want to do fine-grained case-by-case fix (like the current pr), or try to batch multiple fixes (so they won't flood people's notifications)...
I personally prefer multiple small PRs
BTW we should probably figure out how you will get these fixes into DataFusion as there won't be an arrow-rs release for a few weeks
Maybe it is time to create a datafusion "string-view-feature-branch" or something and pin to the head of arrow-rs 🤔
alamb
changed the title
new_null_array for view types
|
I also double checked that this function is what is used by |
2 participants
Which issue does this PR close?
Closes #5893 .
Rationale for this change
Very simple fix + very simple tests
As I start integrating view types in DataFusion, I expect more such unhandled cases to surface. Let me know if we want to do fine-grained case-by-case fix (like the current pr), or try to batch multiple fixes (so they won't flood people's notifications)...
What changes are included in this PR?
Are there any user-facing changes?