Adding compact check functionality to GenericByteViewArray#5720
Adding compact check functionality to GenericByteViewArray#5720ClSlaid wants to merge 3 commits intoapache:mainfrom
Conversation
this part contains compact check functionality for GenericByteViewArray. Signed-off-by: 蔡略 <[email protected]>
Signed-off-by: 蔡略 <[email protected]>
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks for this PR @ClSlaid
Would it be possible please to make a PR with ::gc() as described on #5720? first?
I think the logic to check for compacted is a nice (but new) additional API
This PR doesn't add any new APIs to ByteViewArray -- if we want to consider this code, perhaps we could add one like `GenericByteViewArray::is_compacted()?
But again i consider this a separate task
Signed-off-by: 蔡略 <[email protected]>
ClSlaid
changed the title
I'd implement this first, instead of simultaneously or later. So that I will not bother resolving git conflict 🪢, or have to implement a wasteful full-copying GC algorithm first. :P
As you wish, a new
Exactly. |
|
@alamb Would you kindly retrigger the CI? I don't see anything wrong with my code. |
I believe the CI errors are due to issues that are subsequently fixed (@tustvold fixed #5719 this morning) Thus if you merge up from the |
|
I am very excited to see I still don't fully understand the need for the compact check API in this PR. Perhaps we can make a PR for gc first and then revisit this? |
|
will rewrite after GC merged |
|
Closing this PR as stale. Feel free to reopen if it becomes active again. |
3 participants
This part contains compact check functionality for GenericByteViewArray.
Which issue does this PR close?
Rationale for this change
Part of #5707.
What changes are included in this PR?
GenericByteViewArrayto check if its representation is compact.Are there any user-facing changes?
None.