Fix nested nullability when randomly generating arrays#5713
Merged
alamb merged 8 commits intoapache:masterfrom May 11, 2024
Merged
Fix nested nullability when randomly generating arrays#5713alamb merged 8 commits intoapache:masterfrom
alamb merged 8 commits intoapache:masterfrom
Conversation
alamb
approved these changes
May 11, 2024
Contributor
alamb
left a comment
There was a problem hiding this comment.
Look good (and well tested to me). Thank you @alexwilcoxson-rel
Contributor
|
I believe the docs CI test was fixed on main and the integration test failure is due to #5719 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5712
Rationale for this change
We would like to create random arrays for testing and leveraging data_gen module but it current breaks with our schema of:
More details are provided on issue #5712
What changes are included in this PR?
The changes are isolated to the create_random_array and create_random_list_array functions. Previously the code would assume if the field is not null, set null_density to zero. However that zero is then passed down into nested fields' create_random_array calls, thus resulting in no nulls in those arrays. This PR preserves the original null_density to pass into nested create_random_array calls.
Are there any user-facing changes?
There is a behavior change with array generation with schemas that have nested nullable fields under non-nullable fields.