Conversation
github-actions
bot
added
parquet
| } | ||
| } | ||
|
|
||
| /// This API is only stable since 1.70 so can't use it when current MSRV is lower |
There was a problem hiding this comment.
I simply copy/pasted from is_some_and https://docs.rs/parquet/latest/src/parquet/file/metadata.rs.html#594-596
Otherwise clippy complains like
error: current MSRV (Minimum Supported Rust Version) is `1.62.0` but this item is stable since `1.70.0`
--> arrow-json/src/writer/encoder.rs:163:56
|
163 | let is_null = field_encoder.nulls.as_ref().is_some_and(|n| n.is_null(idx));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: `-D clippy::incompatible-msrv` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::incompatible_msrv)]`
| #[clap(short, long, help("Path to JSON file"))] | ||
| json: String, | ||
| #[clap(value_enum, short, long, default_value_t = Mode::Validate, help="Mode of integration testing tool")] | ||
| #[clap( |
There was a problem hiding this comment.
apparently default_value_t (parsed value) is only available in Rust 1.70
I verified this is the right value (SCREAMING_SNAKE_CASE 🐍 ) like this:
cargo run --bin arrow-json-integration-test| explicit_nulls: bool, | ||
| } | ||
|
|
||
| /// This API is only stable since 1.70 so can't use it when current MSRV is lower |
| // https://github.com/apache/parquet-mr/blob/master/parquet-column/src/main/java/org/apache/parquet/column/values/factory/DefaultV1ValuesWriterFactory.java | ||
| // https://github.com/apache/parquet-mr/blob/master/parquet-column/src/main/java/org/apache/parquet/column/values/factory/DefaultV2ValuesWriterFactory.java | ||
|
|
||
| /// Trait to define default encoding for types, including whether or not the type |
| /// identified by `valid_bits`. | ||
| /// | ||
| /// Returns the number of non-null values encoded. | ||
| #[cfg(test)] |
There was a problem hiding this comment.
only used in tests apparently
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
Can we make sure these aren't exposed publicly
arrow-cast/src/parse.rs
Outdated
|
|
||
| /// This API is only stable since 1.70 so can't use it when current MSRV is lower | ||
| #[inline(always)] | ||
| pub fn is_some_and<T>(opt: Option<T>, f: impl FnOnce(T) -> bool) -> bool { |
There was a problem hiding this comment.
Does this need to be public?
There was a problem hiding this comment.
no it doesn't. I will fix
|
CI failed with some sort of linker error -- I have retriggered it |
|
I believe the archery integration test failure is not related to this PR -- I filed #5719 to track it |
|
Merging to keep things moving along |
3 participants
Which issue does this PR close?
Closes #.
Rationale for this change
Rust 1.78 was released today and it includes new clippy lints
What changes are included in this PR?
Fix the lints
Are there any user-facing changes?
No