Support casting StringView/BinaryView --> StringArray/BinaryArray.#5704
Merged
alamb merged 1 commit intoapache:masterfrom May 6, 2024
Merged
Support casting StringView/BinaryView --> StringArray/BinaryArray.#5704alamb merged 1 commit intoapache:masterfrom
StringView/BinaryView --> StringArray/BinaryArray.#5704alamb merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
I have written some of my thoughts in #5508. |
RinChanNOWWW
force-pushed
the
cast-view-to-byte
branch
from
1f2d150 to
a8f3bfc
Compare
RinChanNOWWW
force-pushed
the
cast-view-to-byte
branch
from
a8f3bfc to
bce9b4d
Compare
8 tasks
Contributor
|
Archery test is failing due to #5719 |
alamb
approved these changes
May 6, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks great to me -- thank you @RinChanNOWWW 🙏
alamb
reviewed
May 6, 2024
| let mut byte_array_builder = GenericByteBuilder::<TO>::with_capacity(len, bytes); | ||
|
|
||
| for val in view_array.iter() { | ||
| byte_array_builder.append_option(val); |
Contributor
There was a problem hiding this comment.
I suspect we could potentially make this code faster by special casing when there are no nulls
This was referenced May 6, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5508.
Rationale for this change
What changes are included in this PR?
Support casting from byte view array (BinaryViewArray, StringVIewArray) to byte array (BinaryArray, StringArray).
Are there any user-facing changes?
No.