Add more invalid utf8 parquet reader tests#5639
Merged
tustvold merged 2 commits intoapache:masterfrom Apr 15, 2024
Merged
Conversation
alamb
changed the title
ariesdevil
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
part of #5530
Rationale for this change
While reviewing #5557 from @ariesdevil it was clear we did not have sufficient invalid utf8 validation tests for reading invalid data from parquet
What changes are included in this PR?
Add error checks for reading invalid utf8 data - both as the first character and embedded characters.
Are there any user-facing changes?
No (I didn't find any bugs 😅 )