optimize the next function of ArrowArrayStreamReader#5248
Merged
tustvold merged 1 commit intoapache:masterfrom Dec 29, 2023
Merged
optimize the next function of ArrowArrayStreamReader#5248tustvold merged 1 commit intoapache:masterfrom
tustvold merged 1 commit intoapache:masterfrom
Conversation
tustvold
approved these changes
Dec 27, 2023
Contributor
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
Looks good to me, thank you
| let data = unsafe { | ||
| from_ffi_and_data_type(array, DataType::Struct(self.schema().fields().clone())) | ||
| } | ||
| .ok()?; |
Contributor
There was a problem hiding this comment.
I know this isn't introduced by this PR, but I wonder why we surpress errors here?
Perhaps @viirya knows?
Member
There was a problem hiding this comment.
Maybe I thought that as self.schema is parsed from imported FFI_ArrowSchema, it should be no error to export it to FFI_ArrowSchema again? It doesn't looks quite correct and I think we should propagate the error.
viirya
approved these changes
Dec 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5103 .