Skip to content

Use new integration scripts (#4963)#4988

Merged
tustvold merged 1 commit intoapache:masterfrom
tustvold:use-new-integration-scripts
Oct 26, 2023
Merged

Use new integration scripts (#4963)#4988
tustvold merged 1 commit intoapache:masterfrom
tustvold:use-new-integration-scripts

Conversation

@tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #4963

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold added the development-process Related to development process of arrow-rs label Oct 25, 2023
@tustvold tustvold marked this pull request as ready for review October 25, 2023 08:57
ARROW_INTEGRATION_CSHARP: ON
ARROW_INTEGRATION_GO: ON
ARROW_INTEGRATION_JAVA: ON
ARROW_INTEGRATION_JS: ON
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, these are ON by default, so you shouldn't need to set them explicitly (though it doesn't hurt to do so).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wanted to make it obvious how to disable an integration should we wish to

Copy link
Contributor

@crepererum crepererum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💪

@tustvold tustvold merged commit b07dabe into apache:master Oct 26, 2023
alamb pushed a commit to alamb/arrow-rs that referenced this pull request Nov 8, 2023
alamb added a commit that referenced this pull request Nov 8, 2023
* Temporarily Disable Java Integration Tests (#4957)

* Add additional integration test dependencies

* Temporarily disable Java

* Remove jpype

* Use new integration scripts (#4963) (#4988)

---------

Co-authored-by: Raphael Taylor-Davies <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of arrow-rs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable Java Integration Tests

3 participants