You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think I would prefer that we add a new with_has_headers and deprecate the old has_headers then once this has percolated through a couple of releases we can potentially repurpose the has_headers to be an accessor.
I think I would prefer that we add a new with_has_headers and deprecate the old has_headers then once this has percolated through a couple of releases we can potentially repurpose the has_headers to be an accessor.我想我更愿意添加一个新的 with_has_headers 并弃用旧的 has_headers ,然后一旦它渗透到几个版本中,我们就可以重新调整 has_headers 的用途成为一个访问者。
I think I would prefer that we add a new with_has_headers and deprecate the old has_headers then once this has percolated through a couple of releases we can potentially repurpose the has_headers to be an accessor.
I think is_has_headers name is better than get_has_headers. Maybe we can now deprecate of it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4735.
Rationale for this change
What changes are included in this PR?
expose the has_header.
Are there any user-facing changes?