Make ArrowRowGroupWriter Public and SerializedRowGroupWriter Send#4850
Merged
tustvold merged 3 commits intoapache:masterfrom Sep 25, 2023
Merged
Make ArrowRowGroupWriter Public and SerializedRowGroupWriter Send#4850tustvold merged 3 commits intoapache:masterfrom
tustvold merged 3 commits intoapache:masterfrom
Conversation
This was referenced Sep 23, 2023
Closed
tustvold
approved these changes
Sep 23, 2023
|
|
||
| /// A [`Read`] for an iterator of [`Bytes`] | ||
| struct ChainReader(Peekable<IntoIter<Bytes>>); | ||
| pub struct ChainReader(Peekable<IntoIter<Bytes>>); |
Contributor
There was a problem hiding this comment.
I think we probably want to rename this to ArrowColumnChunkReader or something, as it will now be public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Enables apache/datafusion#7632
Related to #1718
Rationale for this change
While working on improving DataFusions async parallel parquet writer (draft pr: apache/datafusion#7632), some changes were needed at the arrow level. The DataFusion parallel writer writes separate partitions to different RowGroups in parallel and later concatenates them into one file. Using ArrowRowGroupWriter directly is more efficient for this use case than ArrowWriter and allows retaining column indexes/bloom filters.
What changes are included in this PR?
ArrowRowGroupWriterand related structs/methods are marked publicOnCloseRowGroupclosure is now required to beSendAre there any user-facing changes?
ArrowRowGroupWriter can now be used directly by downstream arrow users.