fix: avoid panic if offset index not exists.#4761
Merged
tustvold merged 2 commits intoapache:masterfrom Sep 4, 2023
Merged
Conversation
Contributor
|
Could we get a test for this please? |
Contributor
Author
Done. PTAL. |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
index_reader::read_pages_locationswill return an emptyVec<PageLocation>if there isn't an offset index:However, it will be set as a
Some(ParquetOffsetIndex)toParquetMetaData'soffset_index.When we read data by a
ChunkReader, we will get page locations of a column byi[rg_idx][self.column_idx]. Buti[rg_idx]maybe empty and it will lead to panic!What changes are included in this PR?
Check if
offset_indexis empty before gettingPageLocationsfrom it.Are there any user-facing changes?
No.