More intuitive bool-to-string casting#4666
Merged
tustvold merged 2 commits intoapache:masterfrom Aug 9, 2023
Merged
Conversation
fsdvh
changed the title
fsdvh
changed the title
Dandandan
approved these changes
Aug 8, 2023
Contributor
|
I have confirmed this is also consistent with ArrayFormatter. Perhaps we could even just remove the special case for boolean to string casting, and use ArrayFormatter as is done for other array types? i.e. update it to use value_to_string instead of a custom iterator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
More intuitive values for default bool-to-string conversion
Rationale for this change
It's non very obvious that bool will be converted to
1or0, I imagine that the main case for such casting would be comparison with string, which I guess should be done using a direct string representation of bool liketrue&falseWhat changes are included in this PR?
The default behavior for bool casting to string
Are there any user-facing changes?
Yes