Skip to content

Cherry pick window::shift to work for all array types to active_release#464

Merged
alamb merged 1 commit intoactive_releasefrom
cherry_pick_0f55b828
Jun 22, 2021
Merged

Cherry pick window::shift to work for all array types to active_release#464
alamb merged 1 commit intoactive_releasefrom
cherry_pick_0f55b828

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jun 19, 2021

Automatic cherry-pick of 0f55b82

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2021 •
edited
Loading

Codecov Report

Merging #464 (bb75c3e) into active_release (1f7f4bc) will increase coverage by 0.02%.
The diff coverage is 98.73%.

❗ Current head bb75c3e differs from pull request most recent head 034841c. Consider uploading reports for the commit 034841c to get more accurate results
Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release     #464      +/-   ##
==================================================
+ Coverage           82.69%   82.71%   +0.02%     
==================================================
  Files                 163      163              
  Lines               44775    44782       +7     
==================================================
+ Hits                37025    37042      +17     
+ Misses               7750     7740      -10
Impacted Files Coverage Δ
parquet/src/encodings/decoding.rs 92.47% <ø> (ø)
parquet/src/arrow/array_reader.rs 77.32% <57.14%> (+0.13%) ⬆️
arrow/src/json/reader.rs 83.76% <97.56%> (+0.11%) ⬆️
arrow/src/array/array_binary.rs 90.15% <100.00%> (ø)
arrow/src/array/array_boolean.rs 90.90% <100.00%> (ø)
arrow/src/array/array_dictionary.rs 84.88% <100.00%> (ø)
arrow/src/array/array_primitive.rs 94.70% <100.00%> (ø)
arrow/src/array/array_struct.rs 88.43% <100.00%> (ø)
arrow/src/array/array_union.rs 86.93% <100.00%> (ø)
arrow/src/array/builder.rs 85.90% <100.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153085f...034841c. Read the comment docs.

@alamb
Copy link
Contributor Author

alamb commented Jun 20, 2021

Needs #475 then rebase to get a clean CI run

@jimexist @alamb
window::shift to work for all array types (#388)
034841c 
* add more doc test for window::shift

* use Ok(make_array(array.data_ref().clone()))

* shift array for not only primitive cases

* include more test cases

* add back copied

* fix renaming
@alamb alamb force-pushed the cherry_pick_0f55b828 branch from ff264ff to 034841c Compare June 20, 2021 11:45
@alamb
Copy link
Contributor Author

alamb commented Jun 21, 2021

Integration failure https://github.com/apache/arrow-rs/pull/464/checks?check_run_id=2868777467 due to some sort of maven problem

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.2:compile (default-compile) on project arrow-plasma: Resolution of annotationProcessorPath dependencies failed: Could not transfer artifact org.immutables:value:jar:2.8.2 from/to central (https://repo.maven.apache.org/maven2): /root/.m2/repository/org/immutables/value/2.8.2/value-2.8.2.jar.part (No such file or directory)
Error:    org.immutables:value:jar:2.8.2

Rerunning

@alamb alamb merged commit b5e50ef into active_release Jun 22, 2021
@alamb alamb deleted the cherry_pick_0f55b828 branch June 22, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alamb @codecov-commenter @jimexist