Conversation
arrow-cast/src/display.rs
Outdated
There was a problem hiding this comment.
I'm not hugely wedded to this format and welcome alternative suggestions. I think faithfully producing the unit of the duration is important, and distinguishes durations from intervals, but otherwise I have no strong opinions
There was a problem hiding this comment.
I need to do some research here --
for example, given 1000ms I think many users would like to see 1 sec. I realize there are details of why this may not always be totally accurately for larger durations...
Maybe something like 1.032 sec could be used to represent the unit (based on number of decimal places...)
There was a problem hiding this comment.
I like the idea of a number of seconds with a decimal
There was a problem hiding this comment.
I've pushed a commit that changes to do this
tustvold
changed the title
tustvold
force-pushed
the
change-duration-format
branch
from
4492805 to
e0bb1bf
Compare
|
So in general I think this change definitely makes the durations more legible. However, I am worried about its backwards compatibility implications (like what will happen to people whose software relies on the old formats? Or has data in the old format?) |
|
Superseded by #4581 |
2 participants
Which issue does this PR close?
Closes #4554
Rationale for this change
Changes the display of durations to be more legible
What changes are included in this PR?
Are there any user-facing changes?