Merged
Conversation
alamb
approved these changes
Jul 10, 2023
arrow-arith/src/numeric.rs
Outdated
| l_s, | ||
| r, | ||
| r_s, | ||
| ((l as i64) - (r as i64)) * 86400 |
Contributor
There was a problem hiding this comment.
The units of Date32 are "seconds" so I understand why to multiply by 86400
For clarity I suggest: naming 86400 something like "SECONDS_IN_A_YEAR" via a const
And is the reason to cast to i64 because that is the native type of DurationSecondType?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4383
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?