Add constructors for FixedSize array types (#3879)#4263
Merged
tustvold merged 2 commits intoapache:masterfrom May 25, 2023
Merged
Add constructors for FixedSize array types (#3879)#4263tustvold merged 2 commits intoapache:masterfrom
tustvold merged 2 commits intoapache:masterfrom
Conversation
alamb
approved these changes
May 24, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
👨🍳 👌 -- looks like a really nice improvement to me
| /// * `!field.is_nullable() && !nulls.expand(size).contains(values.nulls())` | ||
| pub fn try_new( | ||
| field: FieldRef, | ||
| size: i32, |
Contributor
There was a problem hiding this comment.
I think naming this parameter value_length to align with the field name would make it easier to understand
Contributor
Author
There was a problem hiding this comment.
Given it is a FixedSizeArray and not a FixedValueLengthArray I'm personally inclined to stick with size, but will sleep on it
| } | ||
| let mask = buffer.into(); | ||
| self.validate_non_nullable(Some(&mask), 0, child)?; | ||
| let expanded = nulls.expand(element_len); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3879
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?