feat: Prevent UnionArray with Repeated Type IDs#4070
Merged
tustvold merged 5 commits intoapache:masterfrom Apr 12, 2023
Merged
Conversation
tustvold
reviewed
Apr 12, 2023
arrow-schema/src/fields.rs
Outdated
Contributor
There was a problem hiding this comment.
Could we just use bit operations on a u128? It should both be faster and avoid a dependency.
Something like (not tested)
let mut set = 0_u128;
...
let mask = 1_u128 << idx
if (set & mask) != 0 {
Err...
else {
set |= mask
}
Weijun-H
force-pushed
the
prevent-union-array-with-repeated-type-id
branch
from
a63c2fd to
bc17da6
Compare
Contributor
|
Thank you, I think all this now needs is a test |
tustvold
reviewed
Apr 12, 2023
arrow-schema/src/datatype.rs
Outdated
|
|
||
| #[test] | ||
| fn test_union_with_duplicated_type_id() { | ||
| std::panic::set_hook(Box::new(|_info| { |
Contributor
There was a problem hiding this comment.
You can use should_panic for this, there should be examples you can crib from around the codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3982
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?