add Date32/Date64 support to subtract_dyn#3974
Merged
tustvold merged 3 commits intoapache:masterfrom Mar 29, 2023
SinanGncgl:master
Merged
add Date32/Date64 support to subtract_dyn#3974tustvold merged 3 commits intoapache:masterfrom SinanGncgl:master
tustvold merged 3 commits intoapache:masterfrom
SinanGncgl:master
Conversation
tustvold
reviewed
Mar 29, 2023
Contributor
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
Thank you, could we get some tests please
1- add subtract date utilities to types
2- add test for subtract_dyn function
Contributor
Author
I fixed the relevant parts and added test for them. |
tustvold
approved these changes
Mar 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3962.
Rationale for this change
What changes are included in this PR?
Related issue describes clearly.
Are there any user-facing changes?