Skip to content

Parse timestamps with arbitrary seconds fraction#3858

Merged
tustvold merged 2 commits intoapache:masterfrom
tustvold:parse-timestamps-with-arbitrary-fraction
Mar 14, 2023
Merged

Parse timestamps with arbitrary seconds fraction#3858
tustvold merged 2 commits intoapache:masterfrom
tustvold:parse-timestamps-with-arbitrary-fraction

Conversation

@tustvold
Copy link
Contributor

@tustvold tustvold commented Mar 14, 2023 •
edited by alamb
Loading

Which issue does this PR close?

Closes #3859

Rationale for this change

Accidental breaking change in #3801

I have confirmed this has no impact on benchmarks

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 14, 2023
@alamb alamb mentioned this pull request Mar 14, 2023
Closed
@alamb
Copy link
Contributor

alamb commented Mar 14, 2023

Filed #3859 to track

alamb
alamb approved these changes Mar 14, 2023
View reviewed changes
arrow-cast/src/parse.rs
let cases = [
"2020-09-08T13:42:29Z",
"1969-01-01T00:00:00.1Z",
"2020-09-08T12:00:12.12345678+00:00",
Copy link
Contributor

@alamb alamb Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about covering all of the various precision cases (aka

            "2020-09-08T12:00:12+00:00",
            "2020-09-08T12:00:12.1+00:00",
            "2020-09-08T12:00:12.12+00:00",
            "2020-09-08T12:00:12.123+00:00",
            "2020-09-08T12:00:12.1234+00:00",
...
            "2020-09-08T12:00:12.12345678+00:00",

as there is explicit handling for each of them above?

@tustvold tustvold mentioned this pull request Mar 14, 2023
Merged
@tustvold tustvold merged commit 488b7ba into apache:master Mar 14, 2023
@ursabot
Copy link

ursabot commented Mar 14, 2023

Benchmark runs are scheduled for baseline = 047d699 and contender = 488b7ba. 488b7ba is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[REGRESSION] Parsing timestamps with fractional seconds / microseconds / milliseconds / nanoseconds

3 participants

@tustvold @alamb @ursabot