Conversation
Contributor
|
I wonder if this needs to be a new type, there is a non-trivial amount of code that has an implicit assumption that Bitmap is just a wrapper around a |
Member
Author
|
Yea, if you have also looked at my previous PR (closed) for this, it involved more code change. Almost everywhere we currently return null buffer/bitmap and access it needs to be changed. So opened this one to try to have less change if possible. Seems a good idea to be a new type for it. I will try it in the weekend. |
Contributor
|
I plan to add a |
Member
Author
|
Close in favor of #3749 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1802.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?