Skip to content

Comments

Deprecate flight_data_from_arrow_batch#3353

Merged
tustvold merged 6 commits intoapache:masterfrom
Dandandan:deprecate_flight_from_batch
Dec 16, 2022
Merged

Deprecate flight_data_from_arrow_batch#3353
tustvold merged 6 commits intoapache:masterfrom
Dandandan:deprecate_flight_from_batch

Conversation

@Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Dec 16, 2022

Which issue does this PR close?

Closes #3312

Rationale for this change

It encourages inefficient usage of the flight api (as dictionaries are returned over and over). It is relatively easy to use the same API used in this method at the implementation side.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow-flight Changes to the arrow-flight crate label Dec 16, 2022
@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 16, 2022
Dandandan
Dandandan commented Dec 16, 2022
View reviewed changes
arrow-flight/src/utils.rs
let mut dictionaries = vec![];
let mut flight_data = vec![];

let data_gen = writer::IpcDataGenerator::default();
Copy link
Contributor Author

@Dandandan Dandandan Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the basic difference in API (quite limited).

@tustvold
Copy link
Contributor

tustvold commented Dec 16, 2022

Also related - #3354

@tustvold tustvold merged commit 3039633 into apache:master Dec 16, 2022
@ursabot
Copy link

ursabot commented Dec 16, 2022

Benchmark runs are scheduled for baseline = 309cf5c and contender = 3039633. 3039633 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb mentioned this pull request Dec 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tustvold tustvold tustvold approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document / Deprecate arrow_flight::utils::flight_data_from_arrow_batch

3 participants

@Dandandan @tustvold @ursabot