Skip to content

Comments

Remove Unused NativeDecimalType#2945

Merged
tustvold merged 1 commit intoapache:masterfrom
tustvold:remove-native-decimal-type
Oct 27, 2022
Merged

Remove Unused NativeDecimalType#2945
tustvold merged 1 commit intoapache:masterfrom
tustvold:remove-native-decimal-type

Conversation

@tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #2637

Rationale for this change

Follow on to #2865 which removed the only uses of this trait

What changes are included in this PR?

Are there any user-facing changes?

Technically yes, but the only users of this were removed in #2865

@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 27, 2022
@tustvold tustvold merged commit afa8e27 into apache:master Oct 27, 2022
@ursabot
Copy link

ursabot commented Oct 27, 2022

Benchmark runs are scheduled for baseline = 994be05 and contender = afa8e27. afa8e27 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb added the api-change Changes to the arrow API label Oct 28, 2022
@alamb
Copy link
Contributor

alamb commented Oct 28, 2022

I am pretty sure this is a api change in the semver compatible sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Changes to the arrow API arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace DecimalArray with PrimitiveArray

4 participants