Don't validate decimal precision in ArrayData (#2637)#2873
Don't validate decimal precision in ArrayData (#2637)#2873tustvold merged 2 commits intoapache:masterfrom
Conversation
arrow/tests/array_validation.rs
Outdated
| array_data.validate_full().unwrap(); | ||
|
|
||
| let array = Decimal128Array::from(array_data); | ||
| let error = array.validate_decimal_precision(array.precision()).unwrap_err(); |
There was a problem hiding this comment.
It is now explicitly opt-in
|
Benchmark runs are scheduled for baseline = 1eb19b5 and contender = 4d7d411. 4d7d411 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
3 participants
Which issue does this PR close?
Part of #2637
Rationale for this change
As of #2857 we no longer validate precision, we should not do this as part of full ArrayData validation for consistency
What changes are included in this PR?
Disables precision validation as part of ArrayData::validate_values
Are there any user-facing changes?
Sort of, data that would previously fail to validate may now pass. However, we were so inconsistent about applying validation in the first place #2387 I don't imagine anyone could have relied on this.