Skip to content

Split out arrow-integration-test crate#2868

Merged
alamb merged 5 commits intoapache:masterfrom
tustvold:split-out-arrow-integration-test
Oct 14, 2022
Merged

Split out arrow-integration-test crate#2868
alamb merged 5 commits intoapache:masterfrom
tustvold:split-out-arrow-integration-test

Conversation

@tustvold
Copy link
Contributor

@tustvold tustvold commented Oct 13, 2022 •
edited by alamb
Loading

Which issue does this PR close?

Closes #2876

Rationale for this change

Splits out the code to support the arrow integration test JSON format as requested on #2724 (comment) by @maxburke

What changes are included in this PR?

Moves the arrow-integration-testing::util module into a crate which can be published

Renames the integration-testing directory to match the name of the crate ("arrow-integration-testing")

Are there any user-facing changes?

No

@tustvold tustvold requested a review from alamb October 14, 2022 07:04
alamb
alamb approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/integration.yml
- arrow-pyarrow-integration-testing/**
- integration-testing/**
- arrow-integration-test/**
- arrow-integration-testing/**
Copy link
Contributor

@alamb alamb Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the similar naming is unfortunate

@alamb
Copy link
Contributor

alamb commented Oct 14, 2022

Thanks @tustvold

@alamb alamb merged commit 9c5ba92 into apache:master Oct 14, 2022
@ursabot
Copy link

ursabot commented Oct 14, 2022

Benchmark runs are scheduled for baseline = d67d5fb and contender = 9c5ba92. 9c5ba92 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb added the arrow Changes to the arrow crate label Oct 14, 2022
mildbyte added a commit to splitgraph/seafowl that referenced this pull request Oct 26, 2022
@mildbyte
Upgrade DataFusion to 13.0.0, Arrow to 25.0.0
0cb2ed9 
The actual 13.0.0 DF release uses Arrow 24.0.0, but we need to pick up 25.0.0,
since it brings back the Arrow Schema/Field-to-JSON serialization code (albeit
in a different crate for integration tests).

apache/arrow-rs#2868
apache/arrow-rs#2724
mildbyte added a commit to splitgraph/seafowl that referenced this pull request Oct 27, 2022
@mildbyte
Upgrade DataFusion to 13.0.0, Arrow to 25.0.0
3d6368c 
The actual 13.0.0 DF release uses Arrow 24.0.0, but we need to pick up 25.0.0,
since it brings back the Arrow Schema/Field-to-JSON serialization code (albeit
in a different crate for integration tests).

apache/arrow-rs#2868
apache/arrow-rs#2724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restore Integration test JSON schema serialization

3 participants

@tustvold @alamb @ursabot