You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
$ time cargo build --release --no-default-features
________________________________________________________
Executed in 22.13 secs fish external
usr time 120.80 secs 561.00 micros 120.80 secs
sys time 3.70 secs 107.00 micros 3.69 secs
$ time cargo build --release --no-default-features --features dyn_arith_dict
________________________________________________________
Executed in 38.73 secs fish external
usr time 167.26 secs 613.00 micros 167.26 secs
sys time 4.26 secs 106.00 micros 4.26 secs
What changes are included in this PR?
Gates arithmetic operations between primitive dictionary arrays behind a feature flag. Primitive dictionaries are fairly niche, array operations on primitive dictionaries are even more niche. I think the benefits to compilation time justify the overheads of an additional feature flag
Are there any user-facing changes?
Arithmetic operations on dictionaries now require enabling via a feature flag
Benchmark runs are scheduled for baseline = 5b601b3 and contender = 74f639c. 74f639c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api-changeChanges to the arrow APIarrowChanges to the arrow crate
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alamb
changed the title
Which issue does this PR close?
Follow on to #2597
Rationale for this change
What changes are included in this PR?
Gates arithmetic operations between primitive dictionary arrays behind a feature flag. Primitive dictionaries are fairly niche, array operations on primitive dictionaries are even more niche. I think the benefits to compilation time justify the overheads of an additional feature flag
Are there any user-facing changes?
Arithmetic operations on dictionaries now require enabling via a feature flag