Skip to content

Automate updates to CHANGELOG-old.md#2732

Merged
alamb merged 8 commits intoapache:masterfrom
iajoiner:issue-2726
Sep 15, 2022
Merged

Automate updates to CHANGELOG-old.md#2732
alamb merged 8 commits intoapache:masterfrom
iajoiner:issue-2726

Conversation

@iajoiner
Copy link
Contributor

@iajoiner iajoiner commented Sep 15, 2022

Which issue does this PR close?

Closes #2726.

Rationale for this change

What changes are included in this PR?

Automated update to CHANGELOG-old.md

Are there any user-facing changes?

@iajoiner
Copy link
Contributor Author

iajoiner commented Sep 15, 2022

@alamb Here we go!

@alamb
Copy link
Contributor

alamb commented Sep 15, 2022

Thanks @iajoiner

alamb
alamb approved these changes Sep 15, 2022
View reviewed changes
dev/release/update_change_log.sh

# Historical Changelog
' | cat - "${OUTPUT_PATH}" "${OLD_OUTPUT_PATH}" > "${OLD_OUTPUT_PATH}".tmp
mv "${OLD_OUTPUT_PATH}".tmp "${OLD_OUTPUT_PATH}"
Copy link
Contributor

@alamb alamb Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we maybe also remove "${OLD_OUTPUT_PATH}".tmp?

Copy link
Contributor Author

@iajoiner iajoiner Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 70 is a mv so it is already gone.

@iajoiner
Copy link
Contributor Author

iajoiner commented Sep 15, 2022

@alamb I don’t think the random, likely transient error has anything to do with the PR.

@alamb
Copy link
Contributor

alamb commented Sep 15, 2022

I agree -- the docs failure is unrelated #2733

@alamb
Copy link
Contributor

alamb commented Sep 15, 2022

Thanks @iajoiner -- I am going to merge this in and then test it while I make the release notes PR 🙏 thanks again

@alamb alamb merged commit 5238789 into apache:master Sep 15, 2022
@ursabot
Copy link

ursabot commented Sep 15, 2022

Benchmark runs are scheduled for baseline = eb9b456 and contender = 5238789. 5238789 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@iajoiner iajoiner mentioned this pull request Sep 15, 2022
Merged
@iajoiner
Copy link
Contributor Author

iajoiner commented Sep 15, 2022

@alamb Yeah it is a Rust issue and I have filed it over there: rust-lang/rust#101869

@tustvold tustvold added the development-process Related to development process of arrow-rs label Oct 4, 2022
@iajoiner iajoiner deleted the issue-2726 branch April 7, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

development-process Related to development process of arrow-rs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automate updates to CHANGELOG-old.md

5 participants

@iajoiner @alamb @ursabot @tustvold @chloeandmargaret