Don't Derive Serialize/Deserialize Serde Implementations for Schema Types#2723
Closed
tustvold wants to merge 1 commit intoapache:masterfrom
Closed
Don't Derive Serialize/Deserialize Serde Implementations for Schema Types#2723tustvold wants to merge 1 commit intoapache:masterfrom
tustvold wants to merge 1 commit intoapache:masterfrom
Conversation
tustvold
changed the title
Contributor
Author
|
Ok I'm rather confused by this, Edit: It would appear these relate to the integration test plumbing - https://github.com/apache/arrow/blob/0b67673d045bf6e3523277f6802be126661e3001/docs/source/format/Integration.rst#json-test-data-format |
Contributor
Author
|
Closing in favor of #2724 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #2300
Part of #2594
Related to #2711
Rationale for this change
Serde derive is a non-trivial proc macro dependency, and the nature of the orphan rule forces the Serialize/Deserialize implementations to be defined in the same crate. This in turn forces json to leak into an arrow-schema crate, see #2711.
It turns out we aren't actually using the generated code, although downstreams potentially are.
What changes are included in this PR?
Removes the serde derives, ensuring we only provide a single way to serialize a schema to JSON, and potentially allowing this to live in a separate arrow-json crate (#2594)
Are there any user-facing changes?
Yes, theoretically users may have been using these serialize implementations. I'm not sure this duplication was intentional.