Skip to content

Split out integration test plumbing (#2594) (#2300)#2598

Merged
tustvold merged 3 commits intoapache:masterfrom
tustvold:collocate-integration-tests
Aug 28, 2022
Merged

Split out integration test plumbing (#2594) (#2300)#2598
tustvold merged 3 commits intoapache:masterfrom
tustvold:collocate-integration-tests

Conversation

@tustvold
Copy link
Contributor

Which issue does this PR close?

Part of #2594
Part of #2300

Rationale for this change

The way the integration test plumbing is muddled with the core logic is incredibly confusing, and complicates splitting apart the crates (#2594) and adding features flags (#2300)

What changes are included in this PR?

This moves the integration test plumbing to the existing integration-testing. I originally moved it to a separate crate, but this seemed redundant

Are there any user-facing changes?

Technically this functionality was being published, it now isn't. I have confirmed DataFusion isn't making use of this.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 27, 2022
@tustvold tustvold force-pushed the collocate-integration-tests branch from 426065a to ea14618 Compare August 27, 2022 12:01
let mut file = tempfile::tempfile().unwrap();

{
let file =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a drive-by cleanup

@tustvold tustvold requested a review from liukun4515 August 27, 2022 12:25
@tustvold tustvold merged commit c6e7680 into apache:master Aug 28, 2022
@ursabot
Copy link

ursabot commented Aug 28, 2022

Benchmark runs are scheduled for baseline = 6ab208c and contender = c6e7680. c6e7680 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants