Skip to content

Gate dyn comparison of dictionary arrays behind dyn_cmp_dict#2597

Merged
tustvold merged 3 commits intoapache:masterfrom
tustvold:add-dyn-cmp-dict
Aug 27, 2022
Merged

Gate dyn comparison of dictionary arrays behind dyn_cmp_dict#2597
tustvold merged 3 commits intoapache:masterfrom
tustvold:add-dyn-cmp-dict

Conversation

@tustvold
Copy link
Contributor

@tustvold tustvold commented Aug 27, 2022

Which issue does this PR close?

Closes #2596

Rationale for this change

See ticket, improves release compilation times by ~50%.

With dictionary comparison kernels

________________________________________________________
Executed in   84.84 secs    fish           external
   usr time  227.45 secs  662.00 micros  227.44 secs
   sys time    6.23 secs  131.00 micros    6.23 secs

Without dictionary comparison kernels

________________________________________________________
Executed in   21.45 secs    fish           external
   usr time  154.13 secs    0.00 micros  154.13 secs
   sys time    6.24 secs  880.00 micros    6.24 secs

What changes are included in this PR?

Adds a new dyn_cmp_dict feature flag. I opted to not enable this by default as I think the rarity of people relying on this functionality, combined with the significant bloat reduction I think warrants a breaking change.

Are there any user-facing changes?

Yes

@tustvold tustvold added the api-change Changes to the arrow API label Aug 27, 2022
@tustvold tustvold requested a review from viirya August 27, 2022 08:48
@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 27, 2022
@tustvold tustvold merged commit 6ab208c into apache:master Aug 27, 2022
@ursabot
Copy link

ursabot commented Aug 27, 2022

Benchmark runs are scheduled for baseline = 86446ea and contender = 6ab208c. 6ab208c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Sep 1, 2022

Can we possibly document this new flag in https://github.com/apache/arrow-rs/blob/master/arrow/README.md#feature-flags ?

This was referenced Sep 20, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viirya viirya viirya approved these changes

Assignees

No one assigned

Labels

api-change Changes to the arrow API arrow Changes to the arrow crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add dyn_cmp_dict feature flag to gate dyn comparison of dictionary arrays

4 participants

@tustvold @ursabot @alamb @viirya