Skip to content

Fix verify_release.sh script to run rustfmt in each crate individually#2506

Merged
alamb merged 1 commit intoapache:masterfrom
alamb:alamb/fix_verify_script
Aug 18, 2022
Merged

Fix verify_release.sh script to run rustfmt in each crate individually#2506
alamb merged 1 commit intoapache:masterfrom
alamb:alamb/fix_verify_script

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Aug 18, 2022

Which issue does this PR close?

re

Rationale for this change

#2339 changes the release candidates so there is no workspace (Cargo.toml) any longer and thus cargo fmt fails when the verify_release_candidate.sh script is run.

What changes are included in this PR?

Run rustfmt for each of the crates individually -- as the tests were changed in #2339

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of arrow-rs label Aug 18, 2022
@alamb alamb marked this pull request as ready for review August 18, 2022 20:59
@alamb alamb merged commit 68934f0 into apache:master Aug 18, 2022
@alamb alamb deleted the alamb/fix_verify_script branch August 18, 2022 21:11
@ursabot
Copy link

ursabot commented Aug 18, 2022

Benchmark runs are scheduled for baseline = 7ce6ba4 and contender = 68934f0. 68934f0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of arrow-rs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants